Map (s?css|sass) modules to identity-obj-proxy in jest #4419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
suggested changes
May 8, 2018
| @@ -45,11 +45,11 @@ module.exports = (resolve, rootDir, srcRoots) => { | |||
| }, | |||
| transformIgnorePatterns: [ | |||
| '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$', | |||
| '^.+\\.module\\.css$', | |||
| '^.+\\.module\\.(s?css|sass)$', | |||
There was a problem hiding this comment.
Can you change this regular expression to (css|sass|scss)?
| ], | ||
| moduleNameMapper: { | ||
| '^react-native$': 'react-native-web', | ||
| '^.+\\.module\\.css$': 'identity-obj-proxy', | ||
| '^.+\\.module\\.(s?css|sass)$': 'identity-obj-proxy', |
kusold
force-pushed
the
style-modules-jest
branch
2 times, most recently
from
e06834c to
93bdead
Compare
|
We should land this with #4391. |
|
What's the best way to force a retry on the tests? I suspect appveyor just had a failure not caused by this commit. |
|
I just merged #4391, can you merge with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4345
SCSS and SASS modules currently aren't getting transformed, instead they are being resolved by the
fileTransform. This PR instead sends them through theidentity-obj-proxyso that:becomes
when using
jest.